[BEAM-8240] Sets workerHarnessContainerImage in the default Environment of DataflowRunner#9629
Merged
chamikaramj merged 1 commit intoapache:masterfrom Sep 23, 2019
Conversation
Contributor
Author
|
R: @lukecwik |
lukecwik
requested changes
Sep 23, 2019
...e-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
Outdated
Show resolved
Hide resolved
...e-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
Outdated
Show resolved
Hide resolved
...e-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
Outdated
Show resolved
Hide resolved
chamikaramj
force-pushed
the
set_dataflow_env_from_container_image
branch
from
464493a to
82e540b
Compare
Contributor
Author
|
Thanks Luke. PTAL. |
lukecwik
changed the title
lukecwik
approved these changes
Sep 23, 2019
Member
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
nit: It would make more sense to place the test you added within DataflowPipelineTranslatorTest.java
Feel free to fix and then merge or merge as is.
…ayload of the default environment for DataflowRunner
chamikaramj
force-pushed
the
set_dataflow_env_from_container_image
branch
from
82e540b to
4299e38
Compare
Contributor
Author
|
Moved the test. Thanks. |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets workerHarnessContaienrImage as the containerImage of the DockerPayload of the default environment for DataflowRunner
This is similar to change #9583 to Python SDK.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.